Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"About TaxBrain" text needs updating #664

Closed
martinholmer opened this issue Sep 22, 2017 · 6 comments
Closed

"About TaxBrain" text needs updating #664

martinholmer opened this issue Sep 22, 2017 · 6 comments

Comments

@martinholmer
Copy link
Contributor

When you click on "What is TaxBrain?" you are shown the "About TaxBrain" page that includes this text:

screen shot 2017-09-22 at 11 11 48 am

All three links work, but I wonder whether or not the detailed description of the puf.csv file in the second bullet is up-to-date. And even if it is up-to-date now, it seems as if all that information is better kept in the taxdata repository. Or, if not, how can we make sure the text in the second bullet keeps up-to-date?

The third bullet, about the dropq algorithm, is clearly out-of-date. Hasn't the code been through a security review? Certainly the dropq algorithm used by TaxBrain has been open source (as part of the Tax-Calculator repo) for many months. Can this TaxBrain text be updated?

@MattHJensen @feenberg @Amy-Xu @andersonfrailey @hdoupe @GoFroggyRun @brittainhard

@martinholmer martinholmer changed the title About TaxBrain text need updating "About TaxBrain" text needs updating Sep 22, 2017
@hdoupe
Copy link
Collaborator

hdoupe commented Sep 22, 2017

@martinholmer There are some other links that are also out of date. There needs to be an issue to clean up links around the site. One of the hold-ups here is that I'm not sure where this html code is stored. For example there is a link to T.J. in the "What is TaxBrain" page, but the link is broken and I cannot find a reference to T.J. in the current version or the history of templates/pages/docs.html. The fact that I cannot find any reference to T.J. in this document makes me think that this document is not used in the "What is TaxBrain" page even though in most places the text matches up word for word.

@MattHJensen am I missing something?

@martinholmer
Copy link
Contributor Author

martinholmer commented Sep 22, 2017

@hdoupe said:

There needs to be an issue to clean up links around the [PolicyBrain] site. One of the hold-ups here is that I'm not sure where this HTML code is stored.

Check with @MattHJensen about this, but I seem to remember him telling me that much of the HTML text is stored at some kind of private Django website. I think he realizes this contradicts the notion that TaxBrain is open source and as I remember he wanted to integrate that HTML into the PolicyBrain repo, but I guess no progress has been made on that issue.

Maybe immediately after getting 1.0.3 into production, this movement of HTML into the PolicyBrain repo should be a top priority.

@talumbau and @brittainhard, can you give @hdoupe some advice about this matter.

@hdoupe
Copy link
Collaborator

hdoupe commented Jan 17, 2018

PR #711 moves the HTML files from django flatblocks to the repo. We should be ready to tackle this issue now. This fix should be wrapped into the fix for #649

@martinholmer
Copy link
Contributor Author

@hdoupe said on 2018-Jan-17 in issue #664:

PR #711 moves the HTML files from django flatblocks to the repo. We should be ready to tackle this [#664] issue now. This fix should be wrapped into the fix for #649.

As far as I can see on 2018-Nov-06, none of these problems have been fixed.

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 7, 2018

@martinholmer It would be better if this information was located in the Tax-Calculator repo and we pulled it automatically or directed people to it. In the meantime, what would you like these bullets to say? I'll happily make the changes.

@martinholmer
Copy link
Contributor Author

@hdoupe said in issue #664:

It would be better if this information was located in the Tax-Calculator repo and we pulled it automatically or directed people to it.

Just provide a link for each repository (Tax-Calculator and taxdata and ...) to its README.md file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants