[WIP] Limit PDF/ Print Option to Produce Only One Page #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Print output looks great, +1 |
|
@GoFroggyRun looks like we have more merge conflicts. In the future, I think it's best not to modify the vendor files themselves, but use a module separate script that changes the attributes of the original objects. I didn't think about this with the first PRs you made, but I think this code is fine for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #534, the
Printbutton on TaxBrain output page currently produces two pages. See the following screenshot for detail:I tried different ways to limit the number of pages to print via
DataTable.ext.buttons.pdfHtml5andDataTable.ext.buttons.printfunctions (details could be found within the commit), but they do not seem to help.@brittainhard, could you advice what's the best approach to deal with this issue?