Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input_type back to context #767

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Conversation

hdoupe
Copy link
Collaborator

@hdoupe hdoupe commented Dec 8, 2017

@GoFroggyRun's comment in PR #760 led me to this solution. In particular, @GoFroggyRun said:

In particular, before this PR, some code in input_base.html reads:

  {% if input_type == "file" %}
  <script src="{% static 'js/filetb.js' %}"></script>
  {% else %}
  <script src="{% static 'js/taxbrain.js' %}"></script>
  {% endif %}

The if loop here, however, will always fall into the else clause, and thus causing #760.

In PR #641, I removed this from the context. Sometimes I do things that are both extremely frustrating and highly amusing. This happens to be one of them. Check out this comment:
screen shot 2017-12-08 at 3 34 22 pm

@hdoupe
Copy link
Collaborator Author

hdoupe commented Dec 11, 2017

PR #767 is ready for review. It's been pushed to the test server along with changes in #762

@GoFroggyRun
Copy link
Contributor

@hdoupe +1

@hdoupe
Copy link
Collaborator Author

hdoupe commented Dec 11, 2017

Thanks for the review @GoFroggyRun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants