Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add button to allow CPS as input data source #831

Closed
wants to merge 4 commits into from

Conversation

GoFroggyRun
Copy link
Contributor

No description provided.

@GoFroggyRun
Copy link
Contributor Author

@hdoupe this is how I'd like to add the CPS button. I'm having trouble to have those options displayed properly, even if for most part I was mimicking the "Start Year" button.

@GoFroggyRun
Copy link
Contributor Author

GoFroggyRun commented Mar 1, 2018

I'm confused why the new button shows nothing: when I substitute start_years for data_sources, and start_year for default_source, the drop down does show different years as specified in constants.py. But I can't quite figure out why data_sources, default_source won't work.

@hdoupe
Copy link
Collaborator

hdoupe commented Mar 2, 2018

@GoFroggyRun this makes sense to me. In PR #789, I tried to mimic the start year behavior and did not have much success either. Would you mind fixing the merge conflict so that I can check this branch out locally and tinker with it some?

@GoFroggyRun
Copy link
Contributor Author

@hdoupe Thanks! Conflicts are resolved.

@hdoupe
Copy link
Collaborator

hdoupe commented Mar 2, 2018

Thanks @GoFroggyRun

@GoFroggyRun
Copy link
Contributor Author

Closing this in favor of #835

@GoFroggyRun GoFroggyRun closed this Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants