Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display parameter data type as indicated by Tax-Calculator specifications #867

Merged
merged 8 commits into from
Mar 26, 2018

Conversation

hdoupe
Copy link
Collaborator

@hdoupe hdoupe commented Mar 26, 2018

Resolves #866. Also resolves issues relevant to: #795 and #786.

This PR:

  • Displays the default values exactly as Tax-Calculator indicates. This is done by using the parse_value function implemented in Update to Django 1.9 and store parameters as JSON object #822 and the integer value and boolean value flags from current_law_policy.json
  • Updates test TaxCalcParam creation test
  • Moves all parameter display logic to be used by the front-end to param_displayers.py

The benefits repeal section now looks like:

screen shot 2018-03-26 at 4 32 54 pm

@hdoupe hdoupe changed the title Parameters are displayed as type indicated by Tax-Calculator specifications Display parameter data type as indicated by Tax-Calculator specifications Mar 26, 2018
@hdoupe hdoupe merged commit 19a70bc into ospc-org:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant