Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Tax-Calculator 0.22.2 #939

Merged
merged 6 commits into from Nov 5, 2018
Merged

Update to Tax-Calculator 0.22.2 #939

merged 6 commits into from Nov 5, 2018

Conversation

hdoupe
Copy link
Collaborator

@hdoupe hdoupe commented Nov 1, 2018

This PR updates PolicyBrain to Tax-Calculator 0.22.2. I hope to resolve #770 with this PR, too.

Everything looks good with the update except that there's an issue installing taxpuf. I'm going to keep tinkering with that and then take a look at resolving #770.

cc @martinholmer @MattHJensen

@hdoupe hdoupe changed the title Update to Tax-Caclualtor 0.20.2 Update to Tax-Caclualtor 0.22.2 Nov 1, 2018
@hdoupe
Copy link
Collaborator Author

hdoupe commented Nov 1, 2018

I referred to 0.20.2 instead of 0.22.2 in describing this PR, but the changes in the code are correct. That is, Tax-Calculator is updated to 0.22.2.

@hdoupe hdoupe changed the title Update to Tax-Caclualtor 0.22.2 Update to Tax-Caclulator 0.22.2 Nov 1, 2018
@hdoupe hdoupe changed the title Update to Tax-Caclulator 0.22.2 Update to Tax-Calculator 0.22.2 Nov 1, 2018
@hdoupe
Copy link
Collaborator Author

hdoupe commented Nov 1, 2018

@martinholmer are these all of the columns that are expected for the difference table?
screen shot 2018-11-01 at 6 22 00 pm

@martinholmer
Copy link
Contributor

@hdoupe asked in #939:

are these all of the columns that are expected for the difference table?

Yes, it looks like it. There are now two more than there used to be, right?
Thanks for fixing this.

@hdoupe
Copy link
Collaborator Author

hdoupe commented Nov 2, 2018

Yep. No problem, this was a simple fix. It should have been done long ago.

I'll put this on the test server today and try to get it into production tomorrow or on Monday.

@hdoupe
Copy link
Collaborator Author

hdoupe commented Nov 5, 2018

I plan to merge #939 once the tests pass. The merging of this PR was delayed due to installation complications on the PolicyBrain and the PUF package sides.

@hdoupe hdoupe merged commit 5ee5345 into ospc-org:stable Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing statistics in TaxBrain difference table
2 participants