Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement_tree_skip #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yasirroni
Copy link

Solve #14, but I'm not sure if it will introduce bug later. It just work and give consistent optimal result.

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2021

CLA assistant check
All committers have signed the CLA.

@yasirroni
Copy link
Author

Hey @bstellato, would you like to review this?

@@ -109,12 +109,13 @@ def solve(self):
# import pdb; pdb.set_trace()

# 3) Bound and Branch
work.bound_and_branch(leaf)
if not (leaf.x == None).any():
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be changed to if None not in leaf.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants