Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace np.int alias with builtin int #105

Closed
wants to merge 3 commits into from

Conversation

marvinvanaalst
Copy link

This changes the np.int alias of the Python builtin int type as the alias was deprecated in numpy version 1.20.0 and lead to an AttributeError starting with version 1.24.0.

This should fix issue #104

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vineetbansal
Copy link
Contributor

vineetbansal commented Apr 13, 2023

@marvinvanaalst, and sorry for the delay in getting to this, and thanks a bunch for the PR.

2 things before we merge this in:

  • Can you undo the change in pyproject.toml regarding the black configuration? (since its outside the scope of this PR).
  • It looks to me like the alias np.int pointing to int has been in numpy since version 1.7, the current min. version of numpy for osqp. So while I agree that np.int should be replaced with int, there's no need to bump up the required numpy version. If you can change that back in requirements.txt that would be the right thing to do.

@vineetbansal
Copy link
Contributor

@marvinvanaalst - after approving PR #109 with this fix, I'm closing this PR. Release v0.6.2.post9 of osqp incorporates these changes. Thanks for bringing this to our attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants