Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You seem to have forgotten to add the qdldl code #33

Open
klaymartens opened this issue Jun 16, 2023 · 2 comments
Open

You seem to have forgotten to add the qdldl code #33

klaymartens opened this issue Jun 16, 2023 · 2 comments

Comments

@klaymartens
Copy link

You have not actually included the updated qdldl code in your distro....so installs from pypi and even from a download are not working. I manually added the module in to test and install - that worked.

@klaymartens
Copy link
Author

klaymartens commented Jun 16, 2023

Correction - the files are there. They just fail to compile when installing with pip (my bad)

Downloading the package from pypi, and then running pip install . --user gives this
ERROR: Command errored out with exit status 1:
command: /usr/bin/python3 /usr/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py build_wheel /tmp/tmp_4oavvnb
cwd: /home/mds-dc/qdldl-0.1.7
Complete output (59 lines):
running bdist_wheel
running build
running build_ext
Traceback (most recent call last):
File "/home/mds-dc/.local/bin/cmake", line 5, in
from cmake import cmake
ModuleNotFoundError: No module named 'cmake'

But, if I run
python3 setup install --user

It works just fine.

@Jacob-Stevens-Haas
Copy link

Jacob-Stevens-Haas commented Feb 14, 2024

Yeah, there's no 3.12 wheel, and cmake as a dependency is left implicit. Maintainers could add cmake to the build-system/requires table in pyproject.toml, since cmake executable is distributed as a python package as well. It would add some overhead to the build time for devs that already have cmake available on PATH, but 🤷‍♂️ but that's true of any dependency.

Also a duplicate of #26, addressed in #31. Edit: which has now been merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants