Add cmake as a build dependency in the pyproject.toml file #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This will fix building from sdist so will hopefully be future-proof as well but in addition you could upload the wheels built for AArch64 so that M1/M2 Macs can use this package as in #PR |
|
It would be extremely helpful to have this one merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
Self explanatory fix for issues in the build process. The build process can be improved further by using existing well maintained tools for this sort of thing such as scikit build but just committing the minimum changes required.
If you're not tied to conda I would suggest ignoring it and just using Python's build system - it's not perfect but it's come a long way and means that conda would be supported automatically as well as non-conda users