Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a couple of instances of DLONG/DFLOAT being used #48

Merged
merged 1 commit into from Mar 21, 2023

Conversation

vineetbansal
Copy link
Contributor

Noticed a couple of places where we were using the old names (in preparation for a release of qdldl-python). If merged, perhaps we can tag this as v0.1.7?

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2023

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Mar 9, 2023

Pull Request Test Coverage Report for Build 4375947808

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2530813091: 0.0%
Covered Lines: 87
Relevant Lines: 87

💛 - Coveralls

@imciner2 imciner2 merged commit 9a115a5 into master Mar 21, 2023
@imciner2 imciner2 deleted the vb/dtype_renaming branch March 21, 2023 09:33
@imciner2
Copy link
Member

Thanks for catching this! I thought I got all of them, but apparently my find/replace wasn't good enough. I'll tag a new release later today, then you can use that in the python wrappers.

@vineetbansal
Copy link
Contributor Author

Hi @imciner2 - can you do a release? This should fix osqp/qdldl-python#25 I think.

@imciner2
Copy link
Member

imciner2 commented Apr 4, 2023

Ok, the release for 0.1.7 has been made. You can get it at the v0.1.7 tag on the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants