can't build osquery on OS X

[ErikGoldman]

What version of osquery are you using? What operating system. Be specific.

+-----------------+------------+----------+-------------+
| osquery_version | os_version | os_build | os_platform |
+-----------------+------------+----------+-------------+
| 2.6.1           | 10.13.3    | 17D47    | darwin      |
+-----------------+------------+----------+-------------+'

building on 67dd49a (and other versions) produces this error on my machine:

[58%] Building CXX object osquery/events/CMakeFiles/osquery_events_darwin.dir/darwin/kernel_util.cpp.o
[...]/osquery/osquery/events/darwin/kernel_util.cpp:52:12: error: qualified reference to 'SQL' is a constructor name rather than a type in this context
      SQL::SQL(
           ^
1 error generated.

my commands to build were:

git clone https://github.com/facebook/osquery
cd osquery
make deps && make

any idea what's going on? I can post a longer log file for the build but nothing else seemed particularly relevant.

thanks!

[obelisk]

Have you pulled recently? 2.6.1 is quite old and many things have changed since then so it's quite possible that just pulling the new code will fix the issue.

[ilovezfs]

@obelisk we're seeing this in Homebrew CI now too with 3.2.2 https://jenkins.brew.sh/job/Homebrew%20Testing/625/version=high_sierra/testReport/junit/brew-test-bot/high_sierra/install_osquery/

Maybe caused by Xcode 9.3?

[ilovezfs]

also CC @theopolis this doesn't occur with Xcode 9.2 on 10.12.6 but does occur with Xcode 9.3 on 10.13.4

[obelisk]

Investigating.

[obelisk]

Fix is here: #4291

[obelisk]

Fix is landed and build should work now!

[muffins]

Closing this out, feel free to reopen if you have more issues :)