Customizable installation logic #7315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separates out installation logic so that it can easily be overridden in the event of local changes (for example: adding certs to generated packages).
|
|
sharvilshah
requested changes
Sep 20, 2021
cmake/install_directives.cmake
Outdated
| install( | ||
| FILES | ||
| "tools/deployment/macos_packaging/pkg/com.facebook.osqueryd.conf" | ||
| "tools/deployment/macos_packaging/pkg/com.facebook.osqueryd.plist" |
There was a problem hiding this comment.
Not sure where these came from, with the latest release of osquery 5.0.1, com.facebook... identifiers are no longer in use on macOS, instead they are now renamed to io.osquery.agent.conf and io.osquery.agent.plist. There are a couple of macOS specific files missing as well.
Can you please make sure that this is rebased with all the latest changes?
There was a problem hiding this comment.
When I originally put this together we had just finished updating to 4.9.0 :D Clearly I am too slow. I'll get it done.
There was a problem hiding this comment.
OK, try now please.
sharvilshah
reviewed
Sep 20, 2021
|
This looks good, thanks @rlp-apple! |
sharvilshah
approved these changes
Sep 28, 2021
directionless
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates out installation logic so that it can easily be overridden in
the event of local changes (for example: adding certs to generated
packages).