Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cached constraints and columns in xBestIndex #7435

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

Breakwell
Copy link
Contributor

Fixes #7400 - When we call xBestIndex set the Affected tables and clear the cached data when using the QueryPlanner class.

@Breakwell Breakwell requested review from a team as code owners January 7, 2022 14:37
@Breakwell Breakwell changed the title #7400 Clear cached constraints and columns in xBestIndex Clear cached constraints and columns in xBestIndex Jan 7, 2022
@mike-myers-tob mike-myers-tob added core ready for review Pull requests that are ready to be reviewed by a maintainer labels Jan 11, 2022
@mike-myers-tob
Copy link
Member

@Smjert this is just a 2 line change, but I wonder which TSC member knows the most about the SQL core, to review/approve this?

Smjert
Smjert previously approved these changes Jan 18, 2023
@Smjert
Copy link
Member

Smjert commented Jan 18, 2023

Closing and reopening to update the mergeable state.

@Smjert Smjert closed this Jan 18, 2023
@Smjert Smjert reopened this Jan 18, 2023
@Smjert
Copy link
Member

Smjert commented Jan 18, 2023

I took the liberty to do a quick rebase on the master branch to make the build work.

@Smjert Smjert merged commit 08306fb into osquery:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core memory leak ready for review Pull requests that are ready to be reviewed by a maintainer SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EXPLAIN never releases constraints and columns from VirtualTable contents
4 participants