add linwin to list of supported PLATFORM_DIRS #7646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The two tables
intel_me_info
andsecureboot
are being marked as available for all platforms, when it should only be on linux and windows ("linwin"). It is correctly marked as linwin, but the documentation is not generating correctly.This is because the
genwebsitejson.py
file does not contemplate linwin, so it just assumes every platform is supported.This PR adds a linwin key to the PLATFORM_DIRS constant so that it will generate the correct tagging in the JSON.
For broader consideration
Should we not have that try-catch statement? It allows for silent failures like this, if something happens in the future. I'm happy to make that change, if you think this is a good idea.