Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu_info: Port the table to macOS x86 and Apple Silicon #7757

Merged
merged 2 commits into from Feb 15, 2023

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Aug 31, 2022

  • Add two new columns "number_of_efficiency_cores",
    and "number_of_performance_cores".
    This is Apple Silicon only for now,
    but in the future it could be extracted for Linux x86
    and Windows x86 with newer Intel CPUs.

  • Do some minor cleanups to reuse common SMBIOS utils.

  • Enable the cpu_info integration test for Linux and macOS

@Smjert Smjert force-pushed the stefano/feature/cpu-info-macos branch 3 times, most recently from eacdede to d37cd45 Compare September 2, 2022 08:55
@mike-myers-tob mike-myers-tob changed the title cpu_info: Port the table to macOS x86 and Apple Silicon cpu_info: Port the table to macOS x86 and Apple Silicon Sep 16, 2022
@mike-myers-tob mike-myers-tob added the ready for review Pull requests that are ready to be reviewed by a maintainer label Sep 16, 2022
@Smjert Smjert removed the ready for review Pull requests that are ready to be reviewed by a maintainer label Nov 1, 2022
@Smjert Smjert force-pushed the stefano/feature/cpu-info-macos branch from d37cd45 to bffc95b Compare November 1, 2022 15:59
- Add two new columns "number_of_efficiency_cores",
  and "number_of_performance_cores".
  This is Apple Silicon only for now,
  but in the future it could be extracted for Linux x86
  and Windows x86 with newer Intel CPUs.

- Do some minor cleanups to reuse common SMBIOS utils.

- Enable the cpu_info integration test for Linux and macOS
@Smjert Smjert force-pushed the stefano/feature/cpu-info-macos branch from bffc95b to 4ae4a76 Compare January 18, 2023 17:06
@Smjert Smjert marked this pull request as ready for review January 18, 2023 17:06
@Smjert Smjert requested review from a team as code owners January 18, 2023 17:06
directionless
directionless previously approved these changes Feb 3, 2023
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. One question.

osquery/tables/system/posix/smbios_utils.cpp Show resolved Hide resolved
@Smjert Smjert merged commit 042cb99 into osquery:master Feb 15, 2023
@Smjert Smjert deleted the stefano/feature/cpu-info-macos branch February 15, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants