Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a list of Osquery fleet managers #7781

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Conversation

hughneale
Copy link
Contributor

Following on from a quick discussion on Slack. I've added a table to show case the available fleet managers for Osquery.

Following on from a quick discussion on Slack. I've added a table to show case the available fleet managers for Osquery.
@hughneale hughneale requested review from a team as code owners September 29, 2022 19:58
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 29, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

zwass
zwass previously requested changes Oct 26, 2022
README.md Outdated Show resolved Hide resolved
hughneale and others added 2 commits October 26, 2022 19:34
Co-authored-by: Zach Wasserman <zach@fleetdm.com>
Smjert
Smjert previously approved these changes Sep 22, 2023
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little ambivalent about this. But will to go with the flow.

I think it's hard to enumerate everyone. And that makes me wonder if this is the wrong place for it.

README.md Outdated Show resolved Hide resolved
@Smjert
Copy link
Member

Smjert commented Sep 26, 2023

PS: I don't have any investment here, I just approved because there wasn't anything against it and the change request was resolved.

I think the TSC should decide here.

@Smjert Smjert dismissed their stale review September 26, 2023 15:36

Deferring to the TFC

directionless
directionless previously approved these changes Sep 26, 2023
README.md Outdated Show resolved Hide resolved
@alessandrogario
Copy link
Member

alessandrogario commented Sep 26, 2023

I'm a little ambivalent about this. But will to go with the flow.

I think it's hard to enumerate everyone. And that makes me wonder if this is the wrong place for it.

Not against it, just offering an opinion: Kolide and Fleet are both upstream contributors that ensure osquery is well tested against those environments. From the point of view of a user, it may be useful to know this detail when choosing a fleet manager. Without this, it's not immediately clear whether we are endorsing software we tried/develop or just listing 3rd party projects we are not involved in (which may be useful to disclose)

@directionless
Copy link
Member

I'm a little ambivalent about this. But will to go with the flow.
I think it's hard to enumerate everyone. And that makes me wonder if this is the wrong place for it.

Not against it, just offering an opinion: Kolide and Fleet are both upstream contributors that ensure osquery is well tested against those environments. From the point of view of a user, it may be useful to know this detail when choosing a fleet manager. Without this, it's not immediately clear whether we are endorsing software we tried/develop or just listing 3rd party projects we are not involved in (which may be useful to disclose)

I added some text. How's it look to you?

@directionless directionless added this to the 5.10.0 milestone Sep 26, 2023
@alessandrogario
Copy link
Member

I'm a little ambivalent about this. But will to go with the flow.
I think it's hard to enumerate everyone. And that makes me wonder if this is the wrong place for it.

Not against it, just offering an opinion: Kolide and Fleet are both upstream contributors that ensure osquery is well tested against those environments. From the point of view of a user, it may be useful to know this detail when choosing a fleet manager. Without this, it's not immediately clear whether we are endorsing software we tried/develop or just listing 3rd party projects we are not involved in (which may be useful to disclose)

I added some text. How's it look to you?

If you think it's worth mentioning that both Fleet and Kolide are active upstream contributors (contributing not just patches but also a lot of testing at each release) they could maybe be grouped in their own category. Otherwise, this looks good!

@directionless
Copy link
Member

If you think it's worth mentioning that both Fleet and Kolide are active upstream contributors (contributing not just patches but also a lot of testing at each release) they could maybe be grouped in their own category. Otherwise, this looks good!

That seemed like more effort than it's worth right now.

@directionless directionless merged commit cee7617 into osquery:master Sep 28, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants