Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packs/incident_response: process_memory_map is also applicable to Darwin #7789

Merged
merged 2 commits into from
Oct 12, 2022
Merged

packs/incident_response: process_memory_map is also applicable to Darwin #7789

merged 2 commits into from
Oct 12, 2022

Conversation

tstromberg
Copy link
Contributor

This PR updates the process_memory_map query from linux to posix, so that it will execute on macOS machines where it is also beneficial.

@tstromberg tstromberg requested review from a team as code owners October 8, 2022 11:09
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 8, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

directionless
directionless approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the caveat that these packs are wholly unmaintained, and we think we should stop shipping them, this seems fine.

@directionless directionless merged commit e0153cc into osquery:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tstromberg @directionless