Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker_container_stats table to include cached_memory column #7807

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Update docker_container_stats table to include cached_memory column #7807

merged 3 commits into from
Dec 20, 2022

Conversation

LaszloHajduTesco
Copy link
Contributor

The docker container memory usage isn't in sync with docker cli which subtracts the cached memory from the used memory. I added a new column to docker_container_stats to get the cached container memory to get more detailed information about container memory usage.

@LaszloHajduTesco LaszloHajduTesco requested review from a team as code owners November 3, 2022 11:58
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 3, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@mike-myers-tob mike-myers-tob changed the title Getting cached memory of container Add field to docker_container_stats with the cached memory of a container Nov 9, 2022
@mike-myers-tob mike-myers-tob added the ready for review Pull requests that are ready to be reviewed by a maintainer label Nov 9, 2022
@directionless
Copy link
Member

@artemist @zwass

zwass
zwass approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@directionless directionless changed the title Add field to docker_container_stats with the cached memory of a container Update docker_container_stats table to include cached_memory column Dec 20, 2022
@directionless directionless merged commit 3ac6832 into osquery:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwass zwass zwass approved these changes

Assignees
No one assigned
Labels
containers docker Docker tables related. ready for review Pull requests that are ready to be reviewed by a maintainer virtual tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LaszloHajduTesco @directionless @zwass @mike-myers-tob