Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush console buffer during ungraceful exit #7829

Merged
merged 2 commits into from Dec 13, 2022

Conversation

srajaa
Copy link
Contributor

@srajaa srajaa commented Nov 28, 2022

To submit a PR please make sure to follow the next steps:

  • Read the CONTRIBUTING.md guide at the root of the repo.
  • Ensure the code is formatted building the format_check target.
    If it is not, then move the committed files to the git staging area,
    build the format target to format them, and then re-commit.
    More information is available on the wiki.
  • Ensure your PR contains a single logical change.
  • Ensure your PR contains tests for the changes you're submitting.
  • Describe your changes with as much detail as you can.
  • Link any issues this PR is related to.
  • Remove the text above.

@srajaa srajaa requested review from a team as code owners November 28, 2022 09:09
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 28, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@srajaa
Copy link
Contributor Author

srajaa commented Nov 28, 2022

Fixes #7802

@Smjert
Copy link
Member

Smjert commented Nov 28, 2022

Hello @srajaa, thanks for the PR; it seems you have based your PR on an old commit which contains an issue with the read the docs wiki and its step is now failing.
I would suggest to always keep the branch you work on up to date with the latest upstream master branch.

Could you update your local upstream master branch, then from your local PR branch git rebase -i master and check that only the commit of this PR is picked. Finally git push --force-with-lease <fork remote>.

@srajaa
Copy link
Contributor Author

srajaa commented Nov 28, 2022

Sure. Thanks @Smjert

@srajaa
Copy link
Contributor Author

srajaa commented Dec 5, 2022

Hi team, could you kindly look into this ?

@mike-myers-tob mike-myers-tob added user experience ready for review Pull requests that are ready to be reviewed by a maintainer labels Dec 6, 2022
@srajaa
Copy link
Contributor Author

srajaa commented Dec 13, 2022

Thanks @Smjert . Need one more approval.

@Smjert
Copy link
Member

Smjert commented Dec 13, 2022

Thanks @Smjert . Need one more approval.

One approval is enough to merge; I'll merge it now.

@Smjert Smjert merged commit f9a16e1 into osquery:master Dec 13, 2022
@srajaa
Copy link
Contributor Author

srajaa commented Dec 14, 2022

Thank you so much @Smjert . Grateful and appreciated!

@srajaa srajaa deleted the fflush-consolebuufer-ungraceful-exit branch December 14, 2022 17:18
@srajaa
Copy link
Contributor Author

srajaa commented Jan 19, 2023

@Smjert which official build of osqueryi will this be available?

@directionless
Copy link
Member

which official build of osqueryi will this be available?

This merged after we made 5.7.0, so it will land in 5.8.0. Likely sometime before the end of Feburary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull requests that are ready to be reviewed by a maintainer user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants