New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flush console buffer during ungraceful exit #7829
Flush console buffer during ungraceful exit #7829
Conversation
|
Fixes #7802 |
Hello @srajaa, thanks for the PR; it seems you have based your PR on an old commit which contains an issue with the read the docs wiki and its step is now failing. Could you update your local upstream master branch, then from your local PR branch |
Sure. Thanks @Smjert |
Hi team, could you kindly look into this ? |
Thanks @Smjert . Need one more approval. |
One approval is enough to merge; I'll merge it now. |
Thank you so much @Smjert . Grateful and appreciated! |
@Smjert which official build of osqueryi will this be available? |
This merged after we made 5.7.0, so it will land in 5.8.0. Likely sometime before the end of Feburary |
To submit a PR please make sure to follow the next steps:
CONTRIBUTING.md
guide at the root of the repo.format_check
target.If it is not, then move the committed files to the git staging area,
build the
format
target to format them, and then re-commit.More information is available on the wiki.