Add connected_displays table on macOS
#7946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add connected_displays table Add connected_displays table remove nslogs, clean up Add connected_displays table wip
cacab
force-pushed
the
add_connected_displays_table
branch
from
b6798f9
to
f18be28
Compare
cacab
force-pushed
the
add_connected_displays_table
branch
from
011df89
to
76a2b64
Compare
cacab
force-pushed
the
add_connected_displays_table
branch
from
4b04d51
to
f67f22f
Compare
cacab
force-pushed
the
add_connected_displays_table
branch
from
59f4c19
to
c2a6edb
Compare
|
@sharvilshah nudge nudge |
sharvilshah
reviewed
Apr 25, 2023
There was a problem hiding this comment.
Looks great @cacab thanks! Just a couple of minor questions
|
@sharvilshah this is ready for another look when you get a moment |
sharvilshah
approved these changes
May 2, 2023
directionless
changed the title
connected_displays table on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This table adds a connected_displays virtual table which produces multiple rows (depending on the number of displays) giving useful information about a Macbook's internal battery.
Here is what the table looks like for my 15" Macbook Pro 2021:
Why?
This is meant to resolve #7486. This table provides helpful insights into display age, serial numbers, and resolution.