Release objects and free memory obtained from COM #7999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer-dead
commented
Apr 20, 2023
| @@ -431,6 +431,9 @@ Expected<WmiRequest, WmiError> WmiRequest::CreateWmiRequest( | |||
| &authInfo, | |||
| &ifCapabilites); | |||
| if (FAILED(hr)) { | |||
| CoTaskMemFree(serverPrincName); | |||
There was a problem hiding this comment.
https://learn.microsoft.com/en-us/windows/win32/api/objidl/nf-objidl-iclientsecurity-queryblanket
[out] pServerPrincName
The current principal name. The string will be allocated by the callee using the [CoTaskMemAlloc](https://learn.microsoft.com/en-us/windows/desktop/api/combaseapi/nf-combaseapi-cotaskmemalloc) function and must be freed by the caller using the [CoTaskMemFree](https://learn.microsoft.com/en-us/windows/desktop/api/combaseapi/nf-combaseapi-cotaskmemfree) function.
marcosd4h
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me that the COM objects and strings from PR #7963 should be released.
@marcosd4h PTAL