Do not pass wstring::c_str() to wstringToString function #8000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks that the
wstringToString()
function can be called with few types of arguments:std::wstring
objectWCHAR buf[N]
buffer that can be casted toconst wchar_t *
and this is OKstd::wstring("").c_str()
pointer and this is the case I am trying to address with this PRI think that there is no sense to pass a
c_str()
from astd::wstring
object towstringToString
because it will copy the whole string one more time viastd::wstring(const wchat_t*)
constructor in the end. Alsoc_str()
will always return a zero terminated string and never anullptr
pointer value.