Add some indexing to block_devices
#8037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the work originally done in osquery#7209 to the `block_devices` table. With it, I hope to fix an o(n^2) bug. As the underlying code doesn't support this on darwin, I opted to flag the spec as `additional=True` and not `index=True`
mike-myers-tob
added
performance
macOS
Linux
ready for review
sharvilshah
reviewed
Aug 15, 2023
| udev_enumerate_unref(enumerate); | ||
| if (runSelectAll) { | ||
| struct udev_enumerate* enumerate = udev_enumerate_new(udev); | ||
| udev_enumerate_add_match_subsystem(enumerate, "block"); |
There was a problem hiding this comment.
do we need to check if enumerate is not a nullptr?
There was a problem hiding this comment.
I'm not sure? The prior code did not, and of the other places I see this call most don't check.
I can't really find something authoritative, but the code for udev_list_entry_foreach looks like it handles it.
|
|
||
| std::map<std::string, std::string> lvm_lv2pv; | ||
| struct udev_list_entry *devices, *dev_list_entry; | ||
| devices = udev_enumerate_get_list_entry(enumerate); |
There was a problem hiding this comment.
perhaps we should check if devices is also not null before continuing
sharvilshah
approved these changes
Sep 26, 2023
directionless
added a commit
that referenced
this pull request
Oct 5, 2023
This reverts commit b1f3ff6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the work originally done in #7209 to the
block_devicestable. And relates to #8033With it, I hope to fix an o(n^2) bug.
As the underlying code doesn't support this on darwin, I opted to flag the spec as
additional=Trueand notindex=True(Thanks @uptycs-rmack for talking through this with me)