Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cloud_id to ycloud_instance_metadata - the vm metadata table for Yandex Cloud #8086

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

luc-lynx
Copy link
Contributor

Added cloud_id column for ycloud_instance_metadata table.

cloud_id is a container for resources in Yandex Cloud which is similar to a "project" in Google Cloud Platform. This change will allow people that use osquery in Yandex Cloud to get more information about the resource path of their virtual machines.

@luc-lynx luc-lynx requested review from a team as code owners July 20, 2023 20:44
@directionless directionless added this to the 5.10.0 milestone Aug 1, 2023
@luc-lynx
Copy link
Contributor Author

I think virtual tables label should be assigned to the ticket, but I cannot do that myself.

Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have capability to test this in Yandex, but the code does look reasonable.

@zwass zwass merged commit f3d84bb into osquery:master Sep 26, 2023
16 checks passed
@zwass
Copy link
Member

zwass commented Sep 26, 2023

Thank you @luc-lynx!

@luc-lynx
Copy link
Contributor Author

Thanks @zwass !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants