improvement: Avoid unnecessary string conversions #8093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UTF16 and UTF8 conversion APIs already accept std::string and std::wstring correctly, without the need to convert them to a wchar_t or char pointer, which is then converted back to the original type, but with potentially allocating other memory.
Smjert
force-pushed
the
stefano/improvement/utf16-utf8-conversions
branch
from
7b26171
to
62c668e
Compare
directionless
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UTF16 and UTF8 conversion APIs already accept
std::stringandstd::wstringcorrectly, without the need to convert them to a wchar_t or char pointer, which is then converted back to the original type, but with potentially allocating other memory.