Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional chrome extensions paths #8170

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Add additional chrome extensions paths #8170

merged 2 commits into from
Nov 7, 2023

Conversation

victorhaggqvist
Copy link
Contributor

Adds additional Chrome paths, for Google Chrome Beta and Dev, as well as Vivaldi, which are currently not picked up by the chrome extensions table.

@victorhaggqvist victorhaggqvist requested review from a team as code owners October 23, 2023 17:35
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 23, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: victorhaggqvist / name: Victor Häggqvist (1d1824c, 9dd14d3)

zwass
zwass reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Any chance you can also update for the Windows and macOS paths?

@victorhaggqvist
Copy link
Contributor Author

Can do, updated, but I have nothing to easly trial run that on for Windows/macOS, but paths should be ok.

zwass
zwass approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the macOS change manually and the Windows changes look appropriate as well. Thank you!

@zwass zwass merged commit 55145b3 into osquery:master Nov 7, 2023
16 checks passed
@sean-dfir sean-dfir mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwass zwass zwass approved these changes

Assignees
No one assigned
Labels
virtual tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@victorhaggqvist @zwass @Smjert @sharvilshah