fix: Correct the aws_sts_region behavior #8184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `aws_sts_region` flag was controlling the region used by services using STS, like Kinesis and Firehose, instead of controlling which region to generate the STS credential from. This changes the behavior of the flag so it controls the STS credentials region, and it also adds two new flags, `aws_kinesis_region` and `aws_firehose_region` to control the relative services regions.
Smjert
force-pushed
the
stefano/fix/aws-sts-region-flag
branch
from
6614043
to
83b2f11
Compare
zwass
reviewed
Nov 22, 2023
directionless
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aws_sts_regionflag was controlling the region used by services using STS, like Kinesis and Firehose,instead of controlling which region to generate the STS credential from. This changes the behavior of the flag so it controls the STS credentials region, and it also adds two new flags,
aws_kinesis_regionandaws_firehose_regionto control the relative services regions.