fix: Fix a crash in firefox_addons #8227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
previously approved these changes
Dec 22, 2023
Add a return when the "addons" member in the extensions JSON is present but it's not an array, to avoid accessing uninitialized memory. Also check that the "addons" member elements are all objects when trying to access its nested members.
Smjert
force-pushed
the
stefano/fix/firefox-addons-crash
branch
from
d183a1f
to
32c3d3a
Compare
directionless
previously approved these changes
Dec 22, 2023
directionless
previously approved these changes
Dec 22, 2023
|
/easycla |
|
@seph found yet another. The joy of rapidjson. This error might be present in other unrelated code, after having a cursory look. |
directionless
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a return when the "addons" member in the extensions JSON is present but it's not an array, to avoid accessing uninitialized memory.
Also check that the "addons" member elements are all objects when trying to access its nested members.
Should fix #8226