Change message from warning to error when extension could not be loaded #8260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… print error instead of warning. Also, print clearer message.
getvictor
changed the title
getvictor
changed the title
3 tasks
Comment on lines
-92
to
+94
| return Status(1, "Duplicate registry item: " + item.first); | ||
| return Status(1, | ||
| "Registry item " + item.first + | ||
| " conflicts with another item of the same name."); |
There was a problem hiding this comment.
Made the message a bit clearer. We had a customer hitting issues with duplicate table names, so we decided to look into this area and see if we could do something.
There was a problem hiding this comment.
Okay? I think "Duplicate" is pretty clear, and easy to grep for in logs. But I don't think I've hit it, and don't actually have an issue with the rewording.
zwass
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8254
When an extension cannot be loaded due to a duplicate item/extension name, print error instead of warning. Also, print clearer message for duplicate item.