Add windows UBR to os_version table
#8265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncorrect build and version from os_version not as expected on Windows (osquery#7663)
directionless
changed the title
os_version table
directionless
approved these changes
Feb 6, 2024
directionless
requested changes
Feb 6, 2024
directionless
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7908 and #7663
The purpose of this PR is to include the build revision to the build number on windows.
Rationale for this change:
On executing the query
“select build from os_version;”the build does not display the full build number including what is called the updated build revision (UBR) , the implementation of os_version uses the Win32_OperatingSystem WMI class to get all the build information, but it does not have any property that returns the UBR.How is this fixed:
Get this information from windows registry and concatenate it to the build value.
Below screen shot shows, how this would look post fix
