Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing path separator in Safari Extensions table generator #8273

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Micah-Kolide
Copy link
Contributor

@Micah-Kolide Micah-Kolide commented Feb 16, 2024

Fixes #8210

Simple one line change to correct the file path(s) genSafariSandboxedExtensions iterates over. I'm unsure if listDirectoriesInDirectory previously returned the path with the ending separator, but it currently does not seem to do so. Since kSafariAppExtensionsPlistPath is isolated I decided to just add the path separator instead of digging further.

Example:

Pre PR:

/Applications/AdBlock.appContents/PlugIns/%.appex/Contents/Info.plist

Post PR:

/Applications/AdBlock.app/Contents/PlugIns/%.appex/Contents/Info.plist

@Micah-Kolide Micah-Kolide requested review from a team as code owners February 16, 2024 02:19
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for trackin this down!

Fix seems fine, though I wonder if https://www.boost.org/doc/libs/1_34_0/libs/filesystem/doc/index.htm has anything clever in there.

@directionless directionless added this to the 5.12.0 milestone Feb 27, 2024
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that the boost filesystem type could handle this, but it seems unnecessary to me when dealing with a constant -- let's just give it the slash it needs.

@zwass zwass merged commit 5b66192 into osquery:master Feb 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querying safari_extensions returns nothing
3 participants