Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transpiling and move files to dist folder #15

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

cat2608
Copy link
Contributor

@cat2608 cat2608 commented Jan 18, 2018

Add babel to transpile ES6 via script task and create a distribution folder. This change is needed due this ES6 feature

return Math.abs(Number(str.replace(new RegExp(`[^0-9${decimal}]`, 'g'), '').replace(decimal, '.'))) * mult;

@jeremy-richard
Copy link

I agree with @cat2608
When is the ETA on merging this PR? And are you planning to merge this PR?

If not, we will probably fork currencyFormatter.js as it suits our needs but require to support older browsers.
Thank you for your great contribution to the open sources world.

@osrec
Copy link
Owner

osrec commented Jun 14, 2018

Hi Guys, sorry for the delay in merging - we'll get this merged in a couple of days once we've done our review. It's been a busy few weeks in the office, so we haven't had a chance to close a few outstanding issues, but rest assured, this will get sorted very soon :)

@osrec osrec merged commit 61ce51c into osrec:master Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants