Fix missing link to OpenAL in gazebo_util library #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
I tested the fix on a custom GitHub Action-based CI that uses conda-forge provided dependencies, and indeed this seems to solve the problem: traversaro/gazebo-conda-forge-ci#1 . |
|
@osrf-jenkins run tests please. Looks good to me, thanks Silvio. Let's see if we can get a good CI results. |
scpeters
approved these changes
Mar 24, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By inspecting the CMakeLists.txt of gazebo_util due to debugging the problem in RoboStack/ros-noetic#55, I noticed that the if
HAVE_OPENALis defined, the OpenAL library is used ingazebo_util, but it is never linked to it, whilegazebo_utilis linked to it but just withPRIVATEvisibility.Even if this is not the problem that is causing RoboStack/ros-noetic#55 (as I never saw the same problem on Gazebo with Homebrew) in any case this missing link is wrong, so it make sense to fix it.