Change WIN32 to _WIN32
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have been a typo. The correct macro is `_WIN32` as seen elsewhere in this repo and as per the docs: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019 Possibly responsible for ros-tooling/setup-ros#236
|
@wjwwood what's the next step here? How do I get this reviewed and merged? |
wjwwood
approved these changes
Sep 11, 2020
|
Sorry, I missed the notification. This one is not part of our triage I guess or it hasn’t been long enough. Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have been a typo. The correct macro is
_WIN32as seen elsewhere in this repo and as per the docs:https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019
Possibly responsible for ros-tooling/setup-ros#236