Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joint axis always uses parent model frame when nested #219

Closed
osrf-migration opened this issue Sep 4, 2019 · 2 comments
Closed

Joint axis always uses parent model frame when nested #219

osrf-migration opened this issue Sep 4, 2019 · 2 comments
Labels
bug Something isn't working major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Addisu Z. Taddese (Bitbucket: azeey, GitHub: azeey).

The original report had attachments: joint_axis_test.zip


When a model is nested in another model, the joints inside the child model are parsed as though use_parent_model_frame is set to true even if it is not.

Relevant line of code: https://github.com/osrf/sdformat/blob/master/src/parser.cc#L1104

Steps to Reproduce

  1. Extract attached zip file. Place the included_joint folder in your gazebo model database. This can be done by copying the folder to ~/.gazebo/models.
  2. Run gazebo
  3. Spawn the joint_axis_test model by running gz model -f joint_axis_test.sdf -m joint_axis_test

Expected behavior:

The model included_joint has one revolute joint with an axis set to 0 0 1. This model is nested in another model as

<include>
  <uri>model://included_joint</uri>
  <pose>0 0 0.5 0 -1.570796 0</pose>
</include>

Since use_parent_model_frame is not set, this vector is taken to be in the local frame of the child link wheel. The expected behavior is that the axis is aligned with the longitudinal direction of the cylinder.

default_gzclient_camera(1)-2019-09-04T11_02_18.648658.jpg

Actual behavior:

The axis is not aligned with the longitudinal direction of the cylinder because it is rotated by the parent model's pose.

default_gzclient_camera(1)-2019-09-04T11_01_54.664453.jpg

Reproduces how often:

100%

Versions

all

Additional Information

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


see pr #657

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • changed state from "new" to "resolved"

pr #657

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant