CMake fixes #358
Merged
CMake fixes #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 3, 2020 23:08
Signed-off-by: Juan Oxoby <juan@vicarious.com>
Signed-off-by: Juan Oxoby <juan@vicarious.com>
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 87.44% 87.44%
=======================================
Files 60 60
Lines 9337 9337
=======================================
Hits 8165 8165
Misses 1172 1172 Continue to review full report at Codecov.
|
mjcarroll
approved these changes
Sep 4, 2020
|
@osrf-jenkins run tests please |
scpeters
approved these changes
Sep 7, 2020
|
yeah, I don't know why it was working without this fix either. Thanks for the contribution! |
scpeters
pushed a commit
to scpeters/sdformat
that referenced
this pull request
Sep 9, 2020
* Add include(CMakePackageConfigHelpers) * Use modern cmake target for ign-math Signed-off-by: Juan Oxoby <juan@vicarious.com> Co-authored-by: Juan Oxoby <juan@vicarious.com>
scpeters
pushed a commit
that referenced
this pull request
Sep 10, 2020
* Add include(CMakePackageConfigHelpers) * Use modern cmake target for ign-math Signed-off-by: Juan Oxoby <juan@vicarious.com> Co-authored-by: Juan Oxoby <juan@vicarious.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build from Conan, not including
CMakePackageConfigHelpersends in an error saying that it can't findconfigure_package_config_file. I'm not exactly sure why it's actually working without it.Also, use modern CMake target for
ignition-math.