Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new thumbnails #108

Merged
merged 4 commits into from Apr 1, 2020
Merged

Feature/new thumbnails #108

merged 4 commits into from Apr 1, 2020

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Mar 31, 2020

  • reduced quality of OakTree and changed name (see below)

  • changed thumbnail names to link to open source gazebo models:

    • OakTree -> oak_tree
    • PineTree -> pine_tree
    • CafeTable -> cafe_table
    • Fountain -> fountain
    • StandingPerson -> person_standing
    • Postbox -> postbox
  • added new thumbnails:

    • Table
    • ambulance
    • beer
    • cafe
    • construction_barrel
    • construction_cone
    • gazebo
    • lamp_post
    • playground
    • suv

I don't think the thumbnails that have their names changed will affect any of our existing worlds. There is the dilemma that even though we are supporting the open source models, some of them don't follow our CamelCase naming conventions, which makes the list of thumbnail names not uniform. Let me know what your thoughts are.

@codebot
Copy link
Contributor

codebot commented Apr 1, 2020

Yeah, there are Gazebo/Ignition models all over that have various CamelCase or snake_case conventions. I don't think we can enforce either one, so let's just use whatever the upstream model is using.

@aaronchongth aaronchongth merged commit 9ffca7d into master Apr 1, 2020
@aaronchongth aaronchongth deleted the feature/new-thumbnails branch April 1, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants