Focal / Ignition dome dependencies update #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
|
Would this break on Eloquent / Ubuntu 18? Do we need to wait for a simultaneous "grand merge" or simultaneous migration to Foxy? |
|
It shouldn't, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependencies for ignition plugin after version bump in Dome.
Also fixed the traffic_editor package.xml ignition dependencies so they can be installed automatically through rosdep, keys have been added in focal for ignition-plugin and ignition-common3.
Pondering adding a Focal / Foxy workflow, as well as building the plugins (for now the build is only running on the traffic_editor GUI), will probably do in a followup PR.