Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

Add github workflow for Foxy builds #132

Merged
merged 8 commits into from
Sep 22, 2020
Merged

Add github workflow for Foxy builds #132

merged 8 commits into from
Sep 22, 2020

Conversation

luca-della-vedova
Copy link
Member

@luca-della-vedova luca-della-vedova commented Sep 16, 2020

Added workflow for Foxy. Depends on traffic_editor #230, and rmf_schedule_visualizer #79.

Foxy workflow is very similar to eloquent. Due to updates in the rosdep repo we can actually get rid of the manual installation of the ignition libraries needed for traffic editor that are now included in rosdep.

Eloquent build has been removed because the ament_export_targets instruction introduced in rmf_core is not backward compatible and breaks Eloquent builds.

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova luca-della-vedova marked this pull request as ready for review September 21, 2020 04:16
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you update the build instructions in the README file with the changes here? Also, should we remove all mentions of eloquent in the README, if we no longer support it?

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova
Copy link
Member Author

Done, removed all the mentions of eloquent and changed the Eloquent instructions to Ubuntu 18.04 with Foxy from source

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@Yadunund Yadunund merged commit 4639aab into master Sep 22, 2020
@Yadunund Yadunund deleted the foxy_workflows branch September 22, 2020 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants