Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger the creation of new images automatically #36

Closed
osrf-migration opened this issue Aug 24, 2018 · 8 comments
Closed

Trigger the creation of new images automatically #36

osrf-migration opened this issue Aug 24, 2018 · 8 comments
Labels
enhancement New feature or request major
Milestone

Comments

@osrf-migration
Copy link

Original report (archived issue) by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).


When there are changes in the affected branches. DockerHub allows to do this but we need to fix some errors.

@osrf-migration
Copy link
Author

Original comment by Brian Bingham (Bitbucket: brian_bingham).


Need to come up with a reasonable workflow for this

  • what is the criteria for triggering a new build?
  • should we have both a latest build (possibly unstable) based on the head of the default branch and and a stable build?
  • we should make sure that we tag the repository for the stable build so that it is reproducible.

Also need to create some documentation:

  • External docs for users to know what to expect
  • Internal docs on image creation process, etc.

@osrf-migration
Copy link
Author

Original comment by Michael McCarrin (Bitbucket: m1chaelm).


The reason for the errors is that there is no build-time UID in the autobuild environment, so this issue depends on fixing 55 (osrf/vmrc#55)

@osrf-migration
Copy link
Author

Original comment by Michael McCarrin (Bitbucket: m1chaelm).


In addition to the issue above, it looks like the build configuration settings may need to change. I don't think I have permission to access the build settings in the automated build Carlos created on the OSRF DockerHub page. Carlos, do you think you could grant me access?

@osrf-migration
Copy link
Author

Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).


You should have admin access to the osrv/vmrc repository on DockerHub.

@osrf-migration
Copy link
Author

Original comment by Michael McCarrin (Bitbucket: m1chaelm).


Looks like I now have access. Thanks!

@osrf-migration
Copy link
Author

Original comment by Michael McCarrin (Bitbucket: m1chaelm).


I've changed the configuration. Automated builds will now be triggered when a new version tag matching the regex /^[0-9.]+$/ is applied in bitbucket. Once triggered, both the non-nvidia and nvidia versions will be built and tagged with the corresponding version number. For example, release-3.2.0 for the non-Nvidia version and nvidia-3.2.0 for the Nvidia version. At the same time, the "current" and "nvidia-current" tags should be updated to point to the last tagged release.

Since the above options will always be available, we might want to also add "devel" and "nvidia-devel" tags that build on every single push. There is no cost to us to doing this, and it means people who want the absolute latest version can pull it directly from DockerHub. Thoughts?

@osrf-migration
Copy link
Author

Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).


Sounds good to me.

@osrf-migration
Copy link
Author

Original comment by Michael McCarrin (Bitbucket: m1chaelm).


  • changed state from "new" to "resolved"

Since we are now triggering creating of new images automatically, I'm marking this resolved. We can open a new issue if there is a new to add a "devel" image.

@osrf-migration osrf-migration added major enhancement New feature or request labels May 4, 2020
@osrf-migration osrf-migration added this to the 0.3 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major
Projects
None yet
Development

No branches or pull requests

1 participant