Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 ListStatement returns nil values in the first n-entries #1972

Closed
thoro opened this issue Feb 12, 2019 · 1 comment
Closed

v2 ListStatement returns nil values in the first n-entries #1972

thoro opened this issue Feb 12, 2019 · 1 comment

Comments

@thoro
Copy link
Contributor

thoro commented Feb 12, 2019

make(count) and append is used in the ListStatement, therefore always the first count-entries are nil and passed to the callback
thoro added a commit to thoro/gobgp that referenced this issue Feb 12, 2019
@thoro
[Fix osrg#1972] Fix returning of double list size, half nil values
ec5cef6
@fujita
Copy link
Member

fujita commented Feb 14, 2019 •
edited

Nice catch, thanks a lot! Please take look at the review comment.

thoro added a commit to thoro/gobgp that referenced this issue Feb 14, 2019
@thoro
[Fix osrg#1972] Fix returning of double list size, half nil values
7c5fc52
@fujita fujita closed this as completed in 034b889 Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thoro @fujita