server: portability fix for setsockopt() on Linux #1095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some architecture, setsockopt() is a multiplexed syscall and is not available directly (for example, on i386). Instead of invoking the syscall directly, use syscall.SetsockoptString() which is safe as strings are not null-terminated with Go. On BSD, use syscall.SetsockoptInt(), but I don't know if there are architectures with the same limitations as for Linux. Signed-off-by: Vincent Bernat <vincent@bernat.im>
|
So sorry about the delay, it took time to fix the CI system. Now it's back. I've pushed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some architecture, setsockopt() is a multiplexed syscall and is not
available directly (for example, on i386). Instead of invoking the
syscall directly, use syscall.SetsockoptString() which is safe as strings
are not null-terminated with Go.
On BSD, use syscall.SetsockoptInt(), but I don't know if there are
architectures with the same limitations as for Linux. I didn't test, but the change seems trivial.
Signed-off-by: Vincent Bernat vincent@bernat.im