Fixes for BGP-MUP SAFI and support Prefix SID attribute in Interwork/Direct Segment Discovery route #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
higebu
changed the title
higebu
force-pushed
the
fix-mup-2
branch
2 times, most recently
from
233b23e
to
b3d8cf8
Compare
> When advertising the Type 2 ST route, the controller SHOULD attach a BGP MUP Extended community corresponding to the Direct segment. https://www.ietf.org/archive/id/draft-mpmz-bess-mup-safi-01.html#name-generation-of-the-type-2-st
higebu
changed the title
|
Rebased to master branch. |
|
Thanks a lot! Why not add gobgp_mup.md to docs/? |
|
@fujita Thank you for merging. I'll create the PR for docs tomorrow 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is depends on #2586.
Commits:
New version of Usage: https://gist.github.com/higebu/90c0504545978e0cf12cc97b89cb5c81
pcap file: gobgp_mup_pcap_20221014.zip
(You can see this pcap with latest wireshark which can be found at https://www.wireshark.org/download/automated/)