This repository has been archived by the owner on Dec 13, 2021. It is now read-only.
cli: add a new option -cmd option for executing given command to proc… #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @AkihiroSuda |
|
@mitake Thank you a lot and LGTM. How about making the cmd to a non-option argument? e.g. |
| log.Critical("failed to StartProcess: %s", err) | ||
| return 1 | ||
| } | ||
| procState, err := proc.Wait() |
There was a problem hiding this comment.
Wait() blocks until the process exits. https://golang.org/pkg/os/#Process.Wait
So you don't need this Wait()
|
@AkihiroSuda thanks for your comment. I updated this PR, PTAL. The updated version has a mechanism for detecting end of target process. |
| return 1 | ||
| } | ||
|
|
||
| pid = cmd.Process.Pid |
There was a problem hiding this comment.
This pid seems never used because it is overwritten in L96
|
@AkihiroSuda updated for the latest comments, thanks for pointing. PTAL. |
|
@mitake LGTM, thanks! |
|
but CI is failing.. https://travis-ci.org/osrg/namazu/builds/133052785 |
…ess inspector This commit adds a new option -cmd to process inspector. With this option, we don't need to start execution of target before inspection. Below is an example: $ sudo nmz inspectors proc -watch-interval 100ms -autopilot\ dirichlet.toml -cmd "./integration.test -test.v -test.run TestIssue2746\$ -test.count 1000"
|
updated for the CI problem |
|
merging, thank you a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ess inspector
This commit adds a new option -cmd to process inspector. With this
option, we don't need to start execution of target before
inspection. Below is an example:
$ sudo nmz inspectors proc -watch-interval 100ms -autopilot
dirichlet.toml -cmd "./integration.test -test.v -test.run TestIssue2746$ -test.count 1000"