Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author JSON schema for monster data #116

Closed
osrsbox opened this issue Jun 29, 2019 · 6 comments
Closed

Author JSON schema for monster data #116

osrsbox opened this issue Jun 29, 2019 · 6 comments
Assignees
Labels
doing Currently working on this issue/PR monsters Anything to do with the monsters data, API or builder

Comments

@osrsbox
Copy link
Owner

osrsbox commented Jun 29, 2019

As outlined in #16, we have been looking at adding monster data to the orsrbsox-db project for a long time. I will have a lot more time in the next couple months to start development on this issue again.

To start it is essential to specify a schema for the data to be collected and stored. Similar to the item_schema.json, a new JSON schema for monster data should be added to help the building process and testing of the OSRS monsters data.

@osrsbox osrsbox added monsters Anything to do with the monsters data, API or builder doing Currently working on this issue/PR labels Jun 29, 2019
@osrsbox osrsbox self-assigned this Jun 29, 2019
@osrsbox
Copy link
Owner Author

osrsbox commented Jul 11, 2019

Just added a new branch with the JSON schema and pytest module for the monster data. See 066be54 for the changes. If anyone has feedback please post, but there seems less interest in this data, so will continue with my overall plan.

@emerald000
Copy link

FYI: I am quite interested in the monster data. I have plans for a combat helper that would really appreciate a good source of monster info.

@osrsbox
Copy link
Owner Author

osrsbox commented Jul 11, 2019

@emerald000 Oh! That's excellent... glad that you are interested. Feel free to provide any feedback on the general plans - the schema should outline the different monster properties that will be collected. So if you have any other requirements, or see something useful I have missed, please let me know :)

@emerald000
Copy link

I think an image (or link to one) of the monster would be nice. More info is probably needed too for some drops. Like F2P/P2P-only drops. Wilderness-only drops. On Task-only drops. Catacombs-only drops. Drops only during a quest. Probably more I forget.

@osrsbox
Copy link
Owner Author

osrsbox commented Jul 12, 2019

Awesome! Thanks @emerald000 for the feedback. Those additions to the drops object is very useful. I will think about how to add them to make it logical and not add too many additional fields to the existing JSON structure.

@osrsbox
Copy link
Owner Author

osrsbox commented Jul 18, 2019

Closed in commit 7aabb3f.

@osrsbox osrsbox closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doing Currently working on this issue/PR monsters Anything to do with the monsters data, API or builder
Projects
None yet
Development

No branches or pull requests

2 participants