Add monster schema #134
Merged
Add monster schema #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equirements for specific monster drops.
osrsbox
added
enhancement
monsters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #116 - this is the JSON schema for the monster database. This PR moves to add the authored and revised JSON schema into the
masterbranch to allow others to more easily work towards adding in monster data into the project.This PR also adds a pytest module named test/test_monster_database.py. The test can be run using: python -m pytest test/test_monster_database.py when in the root directory of the project. The test is disabled by default so that the project Travis build does not fail. To enable the test, temporarily remove or comment the following line: @pytest.mark.skip(reason="Skipped: The monster data is not currently populated.").