Add some categorizations for GCC exception 3.1 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The updated content was generated by [1]. [1] ./gradlew generateLicenseClassifications Signed-off-by: Frank Viernau <frank_viernau@epam.com>
sschuberth
approved these changes
Dec 28, 2023
| @@ -1082,6 +1082,11 @@ categorizations: | |||
| - "copyleft-limited" | |||
| - "include-in-notice-file" | |||
| - "include-source-code-offer-in-notice-file" | |||
| - id: "GPL-3.0-only WITH GCC-exception-3.1" | |||
There was a problem hiding this comment.
Just FYI, I was thinking (with @willebra and others) about actually allowing to classify exceptions on their own. There's nothing built into ORT that currently prohibits that. And it would have the advantage that you don't need to classify e.g. GCC-exception-3.1 with every license it can be combined with, but only GCC-exception-3.1 on its own. Then, taking into account ORT's exception mapping, you'd know the applicable licenses, and could handle the combination of licenses with exception only in rules, but not yet in the classification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.