feat(curations): Add VCS info for remaning commons-logging-api versions
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
requested changes
Jun 18, 2024
| comment: |- | ||
| No SCM tag in the POM: https://repo1.maven.org/maven2/commons-logging/commons-logging-api/1.0.3/commons-logging-api-1.0.3.pom | ||
| vcs: | ||
| type: "Git" |
There was a problem hiding this comment.
IMO the type and url should be set for a range of versions or agnostic of the version.
There was a problem hiding this comment.
I've extracted these to a version-independent curation now.
| vcs: | ||
| type: "Git" | ||
| url: "https://github.com/apache/commons-logging.git" | ||
| revision: "LOGGING_1_0_3" |
There was a problem hiding this comment.
Is ORT's matching algorithm unable to match this tag?
There was a problem hiding this comment.
No, ORT should be able to match it, see this test for a similar case. But I wanted to be consistent with version 1.1 here, which only uses two digits, and cannot be matched to the three-digit LOGGING_1_1_0 tag.
…ions Extract common VCS info to a version-independent curation. Note that the only other versions of `commons-logging-api` are 1.0.3 and 1.0.4 which have three digits, and thus ORT can match the corresponding three-digit tag names. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
force-pushed
the
all-logging-api-versions
branch
from
095a6cd
to
cf2e87f
Compare
fviernau
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.