Upgrade the spring-core dependency #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/spring-projects/spring-framework/releases/tag/v5.2.9.RELEASE. Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.io>
MarcelBochtler
requested review from
fviernau,
mnonnenmacher and
sschuberth
as code owners
sschuberth
requested changes
Oct 2, 2020
gradle.properties
Outdated
| @@ -55,8 +55,8 @@ postgresEmbeddedVersion = 0.13.3 | |||
| reflectionsVersion = 0.9.12 | |||
| retrofitVersion = 2.9.0 | |||
| semverVersion = 3.1.0 | |||
| simpleExcelVersion = 1.1 | |||
| springCoreVersion = 5.2.8.RELEASE | |||
| simpleExcelVersion = 1.2 | |||
There was a problem hiding this comment.
I believe there was a reason for us not to upgrade this. IIRC, it was because the changelog documents the upgrade to Apache POI 4.1.0, which would break the Excel export for us, whose test is currently disabled because of this. Yeah, the Excel reporter stuff is a bit messy, but I hope to get rid of it completely soon.
TL;DR please drop this for now.
Anyway, please upgrade only one dependency at a time so the commit message can link to the change log of the respective dependency.
There was a problem hiding this comment.
FYI, I decided to remove the simple-excel dependency in #3195.
MarcelBochtler
force-pushed
the
dependency-upgrades
branch
from
033adc5
to
300100a
Compare
sschuberth
approved these changes
Oct 2, 2020
sschuberth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.